Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support outlier table plugin (DHIS2-16751) #2912

Merged
merged 4 commits into from
Mar 5, 2024

Conversation

edoardo
Copy link
Member

@edoardo edoardo commented Feb 16, 2024

Adds support for Outlier table DV items in dashboard DHIS2-16751

Requires dhis2/analytics#1598


Key features

  1. Bump analytics for Outlier table vis type support
  2. Bump @dhis2/ui for the Outlier table icon
  3. Disable the "View as" options in the item's context menu
  4. Revisit tooltip texts now that we have 2 types of "table" visualizations

Description

Outlier table is a new DV vis type, the code required for displaying it it's therefore already in place, but the new vis type definition is in analytics so we need to bump the dependency.
Also, to avoid problems with having multiple versions of @dhis2/ui the dependency is also bumped.


TODO

  • confirm what to do with the "View as" options in the context menu
  • replace the alpha version of analytics with the correct one

Screenshots

Screenshot 2024-02-16 at 11 42 49

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Feb 16, 2024

🚀 Deployed on https://pr-2912--dhis2-dashboard.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify February 16, 2024 10:46 Inactive
@edoardo edoardo force-pushed the fix/support-outlier-table-plugin branch 2 times, most recently from 5b7f9d8 to 199aea8 Compare February 21, 2024 14:38
@edoardo edoardo force-pushed the fix/support-outlier-table-plugin branch 2 times, most recently from 4724007 to 470adef Compare February 29, 2024 10:23
@dhis2-bot dhis2-bot temporarily deployed to netlify February 29, 2024 10:25 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify February 29, 2024 14:40 Inactive
@edoardo edoardo force-pushed the fix/support-outlier-table-plugin branch from d4c4a36 to b060ddb Compare March 4, 2024 14:30
@dhis2-bot dhis2-bot temporarily deployed to netlify March 4, 2024 14:54 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify March 5, 2024 13:15 Inactive
@edoardo edoardo changed the title fix: support outlier table plugin (DHIS2-16751) feat: support outlier table plugin (DHIS2-16751) Mar 5, 2024
@edoardo edoardo merged commit 0ee6322 into dev Mar 5, 2024
26 checks passed
@edoardo edoardo deleted the fix/support-outlier-table-plugin branch March 5, 2024 15:53
dhis2-bot added a commit that referenced this pull request Mar 21, 2024
# [100.1.0](v100.0.4...v100.1.0) (2024-03-21)

### Bug Fixes

* show tag/tooltip about not applied filters for Outlier table (DHIS2-13858) ([#2937](#2937)) ([dffb754](dffb754))
* show tag/tooltip only when a filter other than ou/pe is used ([#2941](#2941)) ([b6b8850](b6b8850))
* **translations:** sync translations from transifex (dev) ([755c6df](755c6df))
* use interpretations component from Analytics (DHIS2-15441) ([#2430](#2430)) ([0af5c5b](0af5c5b))
* **translations:** sync translations from transifex (dev) ([0de3606](0de3606))
* **translations:** sync translations from transifex (dev) ([b88e87c](b88e87c))
* **translations:** sync translations from transifex (dev) ([#2920](#2920)) ([add7139](add7139))

### Features

* support outlier table plugin (DHIS2-16751) ([#2912](#2912)) ([1af22d5](1af22d5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants